Update to FluentAssertions 8.0.0 #128
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: A few tests do not pass yet. Also this will require a major version bump because of the breaking changes.
Owner
|
We should probably also revert these here too https://github.com/adrianiftode/FluentAssertions.Web/pull/73/files#diff-16b69869dba44b9e43f791c9816e95dae2dec0ff7a9ff2cc698a1fb751553bbd Thanks for working on this, I will take a look |
Owner
|
I see there is a discussion regarding licensing. I will have to understand how this goes further. |
Owner
|
Opinions are welcomed. I'm thinking on creating a separate nuget package for v8, something like FluentAssertions.Web.v8 |
|
Owner
|
Will address it here #132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A good piece of the job has been done. I'm opening it as a draft pull request because some more work and discussion is probably needed. A few unit tests do not pass yet and I'm not sure how to best fix them.
Also this will require a major version bump because of the breaking changes.