Skip to content

chore: remove duplicate build command #5884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+8 −2
Closed

chore: remove duplicate build command #5884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1499a4d
chore: remove duplicate build command
caseyisonit Nov 13, 2025
ec3e5e8
chore: changing component for test
caseyisonit Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ commands:
- run:
name: Build the project
command: |
yarn workspace @spectrum-web-components/core build
yarn workspace @spectrum-web-components/1st-gen build

- save_cache:
Expand Down
9 changes: 8 additions & 1 deletion 1st-gen/packages/button/src/CloseButton.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,13 @@ export class CloseButton extends SizedMixin(StyledButton, {
public staticColor?: 'black' | 'white';

protected override get buttonContent(): TemplateResult[] {
return [crossIcon[this.size]()];
return [
crossIcon[this.size](),
html`
<span id="label" class="visually-hidden">
<slot @slotchange=${this.manageTextObservedSlot}></slot>
</span>
`,
];
}
}
Loading