-
Notifications
You must be signed in to change notification settings - Fork 236
chore: publish 2nd generation preview docs in PR #5875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
📚 Branch Preview Links🔍 First Generation Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
TarunAdobe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am okay with merging this but i suppose in future it would be better to have separate workflows for first-gen and second-gen and isolate the scripts? Even different comments maybe idk... it's subjective
marissahuysentruyt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just questions for you! ❓
.github/workflows/preview-docs.yml
Outdated
| pull_request: | ||
| types: [opened, synchronize, reopened, closed] | ||
| branches: | ||
| - '**' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think the preview docs action was failing because of all of the whitespace/indentations in this file? (yaml is white space-sensitive, correct?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ill investigate why my system is applying the white space. thats for calling this out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it linting updates? That's just sort of what it looks like to me. 🤷♀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah its definitely linting related but not sure why its getting applied now. ill check other yaml files too because those didnt get effected the same maybe?
marissahuysentruyt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. All of the new links seem to check out 🥳 and all tests pass in both generations locally.
Description
Generate a PR review link for the 2ng-gen storybook to aid in PR reviews
Motivation and context
Currently all work being done in 2nd-gen requires reviewers to check out the PR and run everything locally. This PR will publish a review link similar to 1st-gen and improves the PR comment to make it explicit which generation the links associate to.
Related issue(s)
Screenshots (if appropriate)
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeaturesManual review test cases
Confirm PR comment works