-
Notifications
You must be signed in to change notification settings - Fork 236
Revert "feat(testing): add Playwright accessibility testing POC for Badge and Status Light (#5835)" #5857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
| { | ||
| "extends": "./tsconfig.json", | ||
| "compilerOptions": { | ||
| "emitDeclarationOnly": false, | ||
| "rootDir": "./", | ||
| "noEmit": true, | ||
| "rootDir": "./" | ||
| "emitDeclarationOnly": false | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected object keys to be in ascending order. 'compilerOptions' should be before 'extends'.
| { | |
| "extends": "./tsconfig.json", | |
| "compilerOptions": { | |
| "emitDeclarationOnly": false, | |
| "rootDir": "./", | |
| "noEmit": true, | |
| "rootDir": "./" | |
| "emitDeclarationOnly": false | |
| }, | |
| { | |
| "compilerOptions": { | |
| "rootDir": "./", | |
| "noEmit": true, | |
| "emitDeclarationOnly": false | |
| }, | |
| "extends": "./tsconfig.json", |
| "compilerOptions": { | ||
| "emitDeclarationOnly": false, | ||
| "rootDir": "./", | ||
| "noEmit": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected object keys to be in ascending order. 'noEmit' should be before 'rootDir'.
| "compilerOptions": { | |
| "emitDeclarationOnly": false, | |
| "rootDir": "./", | |
| "noEmit": true, | |
| "compilerOptions": { | |
| "noEmit": true, | |
| "rootDir": "./", |
| "compilerOptions": { | ||
| "emitDeclarationOnly": false, | ||
| "rootDir": "./", | ||
| "noEmit": true, | ||
| "rootDir": "./" | ||
| "emitDeclarationOnly": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected object keys to be in ascending order. 'emitDeclarationOnly' should be before 'noEmit'.
| "compilerOptions": { | |
| "emitDeclarationOnly": false, | |
| "rootDir": "./", | |
| "noEmit": true, | |
| "rootDir": "./" | |
| "emitDeclarationOnly": false | |
| "compilerOptions": { | |
| "emitDeclarationOnly": false, | |
| "rootDir": "./", | |
| "noEmit": true |
| }, | ||
| "exclude": [ | ||
| "packages/*/node_modules/**/*.ts", | ||
| "tools/*/node_modules/**/*.ts", | ||
| "packages/**/test/*.a11y.spec.ts", | ||
| "test/**/*.ts" | ||
| ], | ||
| "include": [ | ||
| "packages/**/*.ts", | ||
| "tools/**/*.ts", | ||
| "projects/story-decorator/**/*.ts", | ||
| "projects/vrt-compare/**/*.ts" | ||
| ], | ||
| "exclude": [ | ||
| "packages/*/node_modules/**/*.ts", | ||
| "tools/*/node_modules/**/*.ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expected object keys to be in ascending order. 'exclude' should be before 'include'.
| }, | |
| "exclude": [ | |
| "packages/*/node_modules/**/*.ts", | |
| "tools/*/node_modules/**/*.ts", | |
| "packages/**/test/*.a11y.spec.ts", | |
| "test/**/*.ts" | |
| ], | |
| "include": [ | |
| "packages/**/*.ts", | |
| "tools/**/*.ts", | |
| "projects/story-decorator/**/*.ts", | |
| "projects/vrt-compare/**/*.ts" | |
| ], | |
| "exclude": [ | |
| "packages/*/node_modules/**/*.ts", | |
| "tools/*/node_modules/**/*.ts" | |
| }, | |
| "exclude": [ | |
| "packages/*/node_modules/**/*.ts", | |
| "tools/*/node_modules/**/*.ts" | |
| ], | |
| "include": [ | |
| "packages/**/*.ts", | |
| "tools/**/*.ts", | |
| "projects/story-decorator/**/*.ts", | |
| "projects/vrt-compare/**/*.ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets do more due diligence and some sanity testing before we get this in once the release pipeline is fixed.
This reverts commit 1691e33.
Description
This PR introduced regressions that prevent main from building. Additionally, during rebase conflict resolution, it reverted several files to outdated states — for example, unpinned dependency versions in package.json, a stray root-level
@file, and old package scripts and namespaces.Motivation and context
Reverting to unblock
main.Author's checklist