Skip to content

Conversation

@rubencarvalho
Copy link
Contributor

This reverts commit 1691e33.

Description

This PR introduced regressions that prevent main from building. Additionally, during rebase conflict resolution, it reverted several files to outdated states — for example, unpinned dependency versions in package.json, a stray root-level @ file, and old package scripts and namespaces.

Motivation and context

Reverting to unblock main.

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2025

⚠️ No Changeset found

Latest commit: f67a22f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rubencarvalho rubencarvalho marked this pull request as ready for review November 6, 2025 08:53
@rubencarvalho rubencarvalho requested a review from a team as a code owner November 6, 2025 08:53
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5857

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Comment on lines 1 to 7
{
"extends": "./tsconfig.json",
"compilerOptions": {
"emitDeclarationOnly": false,
"rootDir": "./",
"noEmit": true,
"rootDir": "./"
"emitDeclarationOnly": false
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'compilerOptions' should be before 'extends'.

Suggested change
{
"extends": "./tsconfig.json",
"compilerOptions": {
"emitDeclarationOnly": false,
"rootDir": "./",
"noEmit": true,
"rootDir": "./"
"emitDeclarationOnly": false
},
{
"compilerOptions": {
"rootDir": "./",
"noEmit": true,
"emitDeclarationOnly": false
},
"extends": "./tsconfig.json",

Comment on lines 3 to 5
"compilerOptions": {
"emitDeclarationOnly": false,
"rootDir": "./",
"noEmit": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'noEmit' should be before 'rootDir'.

Suggested change
"compilerOptions": {
"emitDeclarationOnly": false,
"rootDir": "./",
"noEmit": true,
"compilerOptions": {
"noEmit": true,
"rootDir": "./",

Comment on lines 3 to +6
"compilerOptions": {
"emitDeclarationOnly": false,
"rootDir": "./",
"noEmit": true,
"rootDir": "./"
"emitDeclarationOnly": false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'emitDeclarationOnly' should be before 'noEmit'.

Suggested change
"compilerOptions": {
"emitDeclarationOnly": false,
"rootDir": "./",
"noEmit": true,
"rootDir": "./"
"emitDeclarationOnly": false
"compilerOptions": {
"emitDeclarationOnly": false,
"rootDir": "./",
"noEmit": true

Comment on lines 7 to +16
},
"exclude": [
"packages/*/node_modules/**/*.ts",
"tools/*/node_modules/**/*.ts",
"packages/**/test/*.a11y.spec.ts",
"test/**/*.ts"
],
"include": [
"packages/**/*.ts",
"tools/**/*.ts",
"projects/story-decorator/**/*.ts",
"projects/vrt-compare/**/*.ts"
],
"exclude": [
"packages/*/node_modules/**/*.ts",
"tools/*/node_modules/**/*.ts"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <jsonc/sort-keys> reported by reviewdog 🐶
Expected object keys to be in ascending order. 'exclude' should be before 'include'.

Suggested change
},
"exclude": [
"packages/*/node_modules/**/*.ts",
"tools/*/node_modules/**/*.ts",
"packages/**/test/*.a11y.spec.ts",
"test/**/*.ts"
],
"include": [
"packages/**/*.ts",
"tools/**/*.ts",
"projects/story-decorator/**/*.ts",
"projects/vrt-compare/**/*.ts"
],
"exclude": [
"packages/*/node_modules/**/*.ts",
"tools/*/node_modules/**/*.ts"
},
"exclude": [
"packages/*/node_modules/**/*.ts",
"tools/*/node_modules/**/*.ts"
],
"include": [
"packages/**/*.ts",
"tools/**/*.ts",
"projects/story-decorator/**/*.ts",
"projects/vrt-compare/**/*.ts"

Copy link
Contributor

@Rajdeepc Rajdeepc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do more due diligence and some sanity testing before we get this in once the release pipeline is fixed.

@rubencarvalho rubencarvalho merged commit 2a78924 into main Nov 6, 2025
22 checks passed
@rubencarvalho rubencarvalho deleted the ruben/revert-playwright branch November 6, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants