Skip to content

Conversation

@rubencarvalho
Copy link
Contributor

@rubencarvalho rubencarvalho commented Nov 4, 2025

Description

Addressed barebones review feedback. Notably:

  1. Documentation updates
  2. Custom HMR plugin that invalidates affected component modules when CSS files change in 2nd-gen
  3. Lint job fix in CI

Even though I fixed some paths related to the Performance tests, these are currently not working in main and will be addressed in post-barebones.

Motivation and context

During the barebones MVP review, feedback indicated that the PR needed some fixes. This addresses that.

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Reviewer's checklist

  • Includes a Github Issue with appropriate flag or Jira ticket number without a link
  • Includes thoughtfully written changeset if changes suggested include patch, minor, or major features
  • Automated tests cover all use cases and follow best practices for writing
  • Validated on all supported browsers
  • All VRTs are approved before the author can update Golden Hash

@changeset-bot
Copy link

changeset-bot bot commented Nov 4, 2025

⚠️ No Changeset found

Latest commit: 9142efb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

📚 Branch Preview

🔍 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-5852

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2025

Tachometer results

Currently, no packages are changed by this PR...

@rubencarvalho rubencarvalho changed the title chore: address linting workflow feedback chore: address barebones feedback Nov 4, 2025
@rubencarvalho rubencarvalho force-pushed the ruben/barebones-feedback branch from 9086e30 to 8f6f6ad Compare November 4, 2025 11:07
@rubencarvalho rubencarvalho force-pushed the ruben/barebones-feedback branch from 8f6f6ad to 2dc3cba Compare November 4, 2025 11:13
@adobe adobe deleted a comment from github-actions bot Nov 4, 2025
@adobe adobe deleted a comment from github-actions bot Nov 4, 2025
@rubencarvalho rubencarvalho marked this pull request as ready for review November 4, 2025 12:47
@rubencarvalho rubencarvalho requested a review from a team as a code owner November 4, 2025 12:47
@rubencarvalho rubencarvalho added Status: Ready for review PR ready for review or re-review. 2nd gen These issues or PRs map to our 2nd generation work to modernizing infrastructure. High priority PR review PR is a high priority and should be reviewed ASAP labels Nov 4, 2025
{
"mustMatch": "Copyright [0-9]{0,4} Adobe. All rights reserved.",
"templateFile": "../../../config/license.js"
"templateFile": "config/HEADER.js"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this is passing in CI, but locally, I'm still getting a lint error:

Image

If I change this to:

Suggested change
"templateFile": "config/HEADER.js"
"templateFile": "../config/HEADER.js"

I can get it to run and it finds lint errors:

Image

Should we address these?

Copy link
Contributor Author

@rubencarvalho rubencarvalho Nov 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I addressed this for now and pushed a commit with the --fixed files.
The more comprehensive linting fix will happen in: #5847
LMK if you still find something quirky!

Copy link
Contributor

@nikkimk nikkimk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rubencarvalho rubencarvalho merged commit 38a2b8f into barebones Nov 4, 2025
19 checks passed
@rubencarvalho rubencarvalho deleted the ruben/barebones-feedback branch November 4, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2nd gen These issues or PRs map to our 2nd generation work to modernizing infrastructure. High priority PR review PR is a high priority and should be reviewed ASAP Status: Ready for review PR ready for review or re-review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants