-
Notifications
You must be signed in to change notification settings - Fork 235
chore: address barebones feedback #5852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
📚 Branch Preview🔍 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
9086e30 to
8f6f6ad
Compare
8f6f6ad to
2dc3cba
Compare
| { | ||
| "mustMatch": "Copyright [0-9]{0,4} Adobe. All rights reserved.", | ||
| "templateFile": "../../../config/license.js" | ||
| "templateFile": "config/HEADER.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I addressed this for now and pushed a commit with the --fixed files.
The more comprehensive linting fix will happen in: #5847
LMK if you still find something quirky!
nikkimk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm


Description
Addressed barebones review feedback. Notably:
Even though I fixed some paths related to the Performance tests, these are currently not working in
mainand will be addressed in post-barebones.Motivation and context
During the barebones MVP review, feedback indicated that the PR needed some fixes. This addresses that.
Author's checklist
Reviewer's checklist
patch,minor, ormajorfeatures