Menu Selects landing branch to Main #1668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables multiple, single, none, and inherited selects for menus. I also updated the menu item aria roles to better match these states. Menu also manages it's own selection with these changes, but we'll tackle actually using that in PickerBase with a followup issue. Re-working the way menu items are managed also made resolving the items ownership async, which required some test changes. Tests were added for the new functionality.
Use the `selects` attribute set to `single` for previous functionality.
Branch Preview URLsWhen a visual regression test fails (or has previously failed while working on this branch), its results will be avaialable at the associated URL below:
|
Tachometer results for changed packagesaction-bar permalink
action-menu permalink
menu permalink
picker permalink
popover permalink
split-button permalink
tooltip permalink
|
adixon-adobe
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges @adixon-adobe previous work and my recent work on Menu selection into
main.I've added this one commit: a3120ab to document the new usage of
sp-action-menuand to ensure that the package is given a "breaking" (in pre-1.0 land feature) version change.See the previous PRs for reference:
Issues referenced:
fixes #350
fixes #715
fixes #1189
fixes #1505