Virtual Trigger as additional option to split what's send to Popper and SWC #1477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westbrook
requested review from
adixon-adobe,
najikahalsema,
spdev3000 and
stanvladut
Westbrook
force-pushed
the
westbrook/overlay-triggers
branch
2 times, most recently
from
e79a6c2 to
016e597
Compare
8 tasks
Westbrook
force-pushed
the
westbrook/overlay-triggers
branch
from
016e597 to
11e0459
Compare
adixon-adobe
previously approved these changes
Jun 1, 2021
| openOverlay( | ||
| trigger, | ||
| 'modal', | ||
| trigger.nextElementSibling as HTMLElement, |
There was a problem hiding this comment.
If I'm understanding this right, clients still pass in an HTMLElement, but now that's just for event bubbling (and focus?), but the virtualTrigger manages positioning. Seems good to me!
Westbrook
changed the title
Westbrook
force-pushed
the
westbrook/overlay-triggers
branch
from
25fa1be to
8e674bf
Compare
stanvladut
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a
virtualTriggeroption to the overlay process that will supersede the element trigger, when available, as part of interaction directly with PopperJS.new VirtualTrigger(x, y)will now provide aVirtualElementthat can be passed an option to theopenOverlaymethods for use as the "trigger" in calls to PopperJS. The element makes public both agetBoundingClientRect()method for position the overlay and aupdateBoundingClientRect(x, y)method for moving the "trigger" of the overlay.updateBoundingClientRect()also callsOverlay.update()internally to reduce the amount of manual interaction required to update overlays opened with the virtual trigger context.Related Issue
fixes #1437
Motivation and Context
Attempt to simplify from #1445
How Has This Been Tested?
Manually in Storybook. If this approach makes sense, some unit tests will be added.
Types of changes
Checklist: