[Bug]: listenerHost can be uninitialized in overlay-trigger-directive

[lehelen19]

Code of conduct

• I agree to follow this project's code of conduct.

Impacted component(s)

overlay-trigger-directive

Library version

1.7.0

Expected behavior

No type errors when this line is run.

Actual behavior

We are seeing errors when an overlay trigger directive's reconnected hook runs and there isn't a listenerHost set in its overridden update(). We should potentially set this.listenerHost = this.target as its parent class does.

Screenshots

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

1. Go to '...'
2. Click on '....'
3. Scroll to '....'
4. Check console
5. See error

Sample code or abstract reproduction which illustrates the problem

No response

Severity

None

Logs taken while reproducing problem

No response

Would you like to track this issue in Jira?

• Yes, please tell me the ticket number!

[najikahalsema]

SWC-1335

[Rajdeepc]

@lehelen19 if we set this.listenerHost = this.target (the trigger button), the event listener is attached to the wrong element. The overlay dispatches the event on itself, not on the trigger. The problem is a race condition: reconnected() calls init() -> init() tries to attach listener to this.listenerHost. But this.listenerHost is only set inside the async handleOverlayReady callback. If reconnection happens before the overlay is ready → crash.
We should override reconnected in child class. This will not break the parent class contract.

override reconnected(): void {
    if (this.listenerHost) {
        this.init();
    }
}

cc @TarunAdobe