-
Notifications
You must be signed in to change notification settings - Fork 234
Closed
Labels
Component: OverlayDocumentationPost overlay APIReview after Overlay V2 ShipsReview after Overlay V2 ShipsPriorityneeds jira ticket
Description
Code of conduct
- I agree to follow this project's code of conduct.
Description of issue
Our overlay component is pretty complex, and our docs should cover those complexities. When we did a walkthrough of how to consume this component, there were a few things that weren't clear in the documentation. I think it would be great if we could write these docs in plain language and include examples for all the different usages we outline. Some specific things I noticed:
- The
TriggerInteraction
example is using'click'
, but what we discussed pointed to'modal'
being the most accessible interaction to use. This isn't clear, and if I were a consumer, I would probably default to'click'
since that's the example the docs give me. Some further description of the different types of interactions would help our consumers decide which is best for their use case. - Styling the component should be expounded upon to explain the 3 methods of inline styles, a
<style>
tag, and usage of css. Including examples for each. - Documenting how to use the
VirtualTrigger()
. - Should we include documentation for managing focus and position?
- What about documenting how the overlay interacts with the shadowDOM/light DOM/DOM tree in general?
Metadata
Metadata
Assignees
Labels
Component: OverlayDocumentationPost overlay APIReview after Overlay V2 ShipsReview after Overlay V2 ShipsPriorityneeds jira ticket