-
Notifications
You must be signed in to change notification settings - Fork 234
Closed
Labels
Component: DialogComponent: OverlayOverlay v2 ConfirmedPost overlay APIReview after Overlay V2 ShipsReview after Overlay V2 Shipsa11yIssues related to accessibilityIssues related to accessibilitybugSomething isn't workingSomething isn't working
Description
Code of conduct
- I agree to follow this project's code of conduct.
Impacted component(s)
dialog / dialog wrapper
Expected behavior
aria-modal and role=dialog are on different elements.
These have to be on the same element per the aria spec https://w3c.github.io/aria/#aria-modal
Actual behavior
When rendering a dialog using dialog wrapper the role=dialog gets rendered on the sp-dialog element but aria-modal=true gets rendered on the active-overlay element.
Screenshots
No response
What browsers are you seeing the problem in?
No response
How can we reproduce this issue?
- Go to dialog wrapper https://opensource.adobe.com/spectrum-web-components/components/dialog-wrapper/
- Click on toggle dialog
- inspect the DOM
Sample code that illustrates the problem
No response
Logs taken while reproducing problem
No response
Metadata
Metadata
Assignees
Labels
Component: DialogComponent: OverlayOverlay v2 ConfirmedPost overlay APIReview after Overlay V2 ShipsReview after Overlay V2 Shipsa11yIssues related to accessibilityIssues related to accessibilitybugSomething isn't workingSomething isn't working