Skip to content

[Overlay] Control when work is done #1512

New issue
New issue
Closed
#1682
Closed
[Overlay] Control when work is done#1512
#1682
Labels
Component: OverlayPerformance
@Westbrook

Description

@Westbrook
Westbrook
opened on Jun 7, 2021

We can control when work is done, while also allowing pre-<body> loading of JS (if required) by revisiting when these events are added in support of the overlay stack.

spectrum-web-components/packages/overlay/src/overlay-stack.ts

Lines 154 to 159 in 1ffdbe1

private addEventListeners(): void {
this.document.addEventListener('click', this.handleMouseCapture, true);
this.document.addEventListener('click', this.handleMouse);
this.document.addEventListener('keyup', this.handleKeyUp);
window.addEventListener('resize', this.handleResize);
} 

private get document(): Document {
    return this.root.ownerDocument /* c8 ignore next */ || document;
}

The this.document values resolve to undefined when run before <body> preventing page blocking JS loading techniques.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Component: OverlayPerformance

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions