Skip to content

Oddly shaped focus outline when opening sp-dialog #1133

@davidclark87

Description

@davidclark87

Expected Behaviour

I wouldn't expect to see a focus outline around a newly opened dialog. If we are deliberately showing this outline for accessibility purposes, I'd expect it to closely wrap the contours of the dialog rather than extend across the full viewport width. FWIW, React Spectrum dialogs don't have such an outline.

Actual Behaviour

"Small" example on docs site:
image

Fullscreen mode example (Fullscreen takeover mode exhibits same behavior, but the outline is eventually covered by the dialog once the opening animation completes):
image

Reproduce Scenario (including but not limited to)

Steps to Reproduce

  1. Go to https://opensource.adobe.com/spectrum-web-components/components/dialog-wrapper/examples
  2. Click any of the "Toggle dialog" buttons on that page (e.g. the "Small" example)

Platform and Version

Tested on Mac: Occurs on Chrome and Edge; does not occur on Safari or Firefox.
Not tested on Windows.

Sample Code that illustrates the problem

See docs site

Logs taken while reproducing problem

N/A

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions