Skip to content

fix: properly handle 0 as row ID #9087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2025
Merged

fix: properly handle 0 as row ID #9087

merged 2 commits into from
Oct 23, 2025

Conversation

@chirokas
Copy link
Contributor

@chirokas chirokas commented Oct 23, 2025

Closes #9081

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@chirokas chirokas marked this pull request as ready for review October 23, 2025 15:00
reidbarber
reidbarber approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

snowystinger
snowystinger approved these changes Oct 23, 2025
View reviewed changes
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for editing the story which we also import into tests!

@snowystinger snowystinger added this pull request to the merge queue Oct 23, 2025
Merged via the queue into adobe:main with commit 4509db3 Oct 23, 2025
31 checks passed
@chirokas chirokas deleted the table-handle-zero-row-id branch October 24, 2025 02:02
@barvian
Copy link

barvian commented Oct 24, 2025

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snowystinger snowystinger snowystinger approved these changes

@reidbarber reidbarber reidbarber approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RAC Table errors when using numeric row IDs

4 participants

@chirokas @barvian @snowystinger @reidbarber