fix(RAC): ensure Input autoFocus works when opening Modal from MenuItem via keyboard #8881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowystinger
approved these changes
Sep 18, 2025
Member
snowystinger
left a comment
snowystinger
left a comment
There was a problem hiding this comment.
I think this is fine. We'll want to focus testing around leaving the browser/coming back either though visiting another application or switching tabs and with submenus.
Thanks for the PR!
LFDanLu
approved these changes
Oct 8, 2025
Member
LFDanLu
left a comment
LFDanLu
left a comment
There was a problem hiding this comment.
Verified the behavior locally, thanks for the PR. The other case mentioned via #8791 (comment) seems to be due to something else, digging right now but this change here is fine to go in IMO.
devongovett
pushed a commit
that referenced
this pull request
Oct 9, 2025
…em via keyboard (#8881) * fix(RAC): ensure Input autoFocus works when opening Modal from MenuItem via keyboard * fix: react.act is not a function --------- Co-authored-by: Daniel Lu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8791
When a MenuItem is triggered via keyboard, it enters the virtual interaction mode (see the related code here). In this mode, the
focusSafelyfunction defers focus usingrunAfterTransition. However, by the time the callback is executed, the MenuItem (i.e., thelastFocusedElement) has already been unmounted. As a result, focus falls back to the body, causing focus failure.✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: