Skip to content

fix: Properly allow user to keyboard edit the Autocomplete input field when collection becomes empty #8861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2025
Merged

fix: Properly allow user to keyboard edit the Autocomplete input field when collection becomes empty #8861

merged 1 commit into from
Sep 12, 2025

Conversation

@LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Sep 12, 2025

Closes #8855, #8856

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Test should cover the broken case, but sanity check the other autocomplete stories

🧢 Your Project:

RSP

@LFDanLu
fix: Properly allow user to keyboard edit the Autocomplete input fiel…
099b69a 
…d when collection becomes empty

aria-activedescendat sticks around in some cases, will still need to be properly fixed but this at least makes sure the user doesnt get stuck
@LFDanLu LFDanLu linked an issue Sep 12, 2025 that may be closed by this pull request
Autocomplete input stops updating when no matches are found #8856
Closed
@rspbot
Copy link

rspbot commented Sep 12, 2025

Build successful! 🎉

@sfc-gh-alisowski
Copy link

sfc-gh-alisowski commented Sep 12, 2025

Thanks for the quick response on this!

@LFDanLu LFDanLu added this pull request to the merge queue Sep 12, 2025
Merged via the queue into main with commit ee5c451 Sep 12, 2025
32 checks passed
@LFDanLu LFDanLu deleted the fix_8856 branch September 12, 2025 20:21
LFDanLu added a commit that referenced this pull request Sep 12, 2025
@LFDanLu
fix: Properly allow user to keyboard edit the Autocomplete input fiel…
0e5046d 
…d when collection becomes empty (#8861)

aria-activedescendat sticks around in some cases, will still need to be properly fixed but this at least makes sure the user doesnt get stuck
devongovett pushed a commit that referenced this pull request Sep 12, 2025
@LFDanLu @devongovett
fix: Properly allow user to keyboard edit the Autocomplete input fiel…
68908f3 
…d when collection becomes empty (#8861)

aria-activedescendat sticks around in some cases, will still need to be properly fixed but this at least makes sure the user doesnt get stuck
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devongovett devongovett devongovett approved these changes

@reidbarber reidbarber reidbarber approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Autocomplete input stops updating when no matches are found [Select] Search input stops updating after no matches are found

6 participants

@LFDanLu @rspbot @sfc-gh-alisowski @devongovett @reidbarber