chore: avoid showing placeholder warning every render #8682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
LFDanLu
approved these changes
Aug 6, 2025
yihuiliao
approved these changes
Aug 6, 2025
snowystinger
reviewed
Aug 6, 2025
| if (placeholder && process.env.NODE_ENV !== 'production') { | ||
| console.warn('Placeholders are deprecated due to accessibility issues. Please use help text instead. See the docs for details: https://react-spectrum.adobe.com/react-spectrum/SearchField.html#help-text'); | ||
| } | ||
| let hasWarned = useRef(false); |
Member
There was a problem hiding this comment.
make into a usePlaceholderWarning({placeholder, message}) hook?
Member
Author
There was a problem hiding this comment.
I was thinking a larger dev-only runtime hook might be useful? Maybe we can think more about this.
Member
There was a problem hiding this comment.
yeah, i was just thinking to reduce code size as a result of duplication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3250
Not a huge deal, just cleaning up some old issues. We can close if we think this isn't worth including since we now only show in production.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: