Skip to content

Conversation

@yihuiliao
Copy link
Member

Noticed that the examples in the docs weren't quite working while figuring out the demo for the intern presentation. It does work without adding the as const locally but the type error can be confusing

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@yihuiliao yihuiliao changed the title docs: update examples to fix type error docs: update s2 examples to fix type error Jun 17, 2025
@rspbot
Copy link

rspbot commented Jun 17, 2025

Build successful! 🎉

Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hopefully people know this is typescript and not javascript :D

@yihuiliao yihuiliao added this pull request to the merge queue Jun 18, 2025
Merged via the queue into main with commit 5cb35d6 Jun 18, 2025
31 checks passed
@yihuiliao yihuiliao deleted the update-s2-docs branch June 18, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants