Skip to content

Conversation

@snowystinger
Copy link
Member

Closes

Ran chromatic https://www.chromatic.com/build?appId=5f0dd5ad2b5fc10022a2e320&number=971

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Jun 17, 2025

Build successful! 🎉

@devongovett
Copy link
Member

Did you do a diff? Any new tokens we should be adding to our theme?

@snowystinger
Copy link
Member Author

snowystinger commented Jun 18, 2025

Thanks for the reminder. Ran it, notable changes:
wireframe color updates, we don't use this

something about a stack-item, I don't know what this one is. i assume component specific

link-out-icon got two new sizes, not sure why, one of the new ones is the same as the existing ones (300 is the same as existing 200)

  "link-out-icon-size-300": {
    "sets": {
      "desktop": {
        "value": "14px",
        "uuid": "66e386cd-e3b5-424b-b89b-27fe9aaf5ad1"
      },
      "mobile": {
        "value": "16px",
        "uuid": "a063db0d-81cf-45e0-988e-2224307560ba"
      }
    }
  },
  "link-out-icon-size-400": {
    "sets": {
      "desktop": {
        "value": "16px",
        "uuid": "54227cbe-b962-46de-b40a-d1ea759425a7"
      },
      "mobile": {
        "value": "18px",
        "uuid": "1bcd281a-38b0-4e83-8667-536351dd14ec"
      }
    }
  },

many card, steplist, segmented control, calendar/date/time, accordion, tagfield, listview, field, actionbar, popover specific tokens have been added

new add-icon, drag-handle-icon, gripper-icon have been added

new visual-to-control-100, label-to-description-0, and line-height tokens have been added, we might want some of these

Here's a zip with before and after for diffing
spectrum-tokens-diffing.zip

@snowystinger snowystinger added this pull request to the merge queue Jun 18, 2025
Merged via the queue into main with commit 3423f9c Jun 18, 2025
30 checks passed
@snowystinger snowystinger deleted the update-spectrum-tokens branch June 18, 2025 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants