Skip to content

Conversation

@LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Jun 10, 2025

This partially reverts commit 190e7e2. The tree loading indicator focus will remain reverted since there are larger collection level refactors that will need to happen to support that use case as a whole

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

RSP

@rspbot
Copy link

rspbot commented Jun 10, 2025

Build successful! 🎉

snowystinger
snowystinger previously approved these changes Jun 10, 2025
yihuiliao
yihuiliao previously approved these changes Jun 11, 2025
@LFDanLu
Copy link
Member Author

LFDanLu commented Jun 16, 2025

Hold off on merging this PR in, debating if we should refactor the loading sentinels first before re-adding this keyboard focus behavior

@LFDanLu LFDanLu changed the title chore: Revert "chore: revert focus loading indicators and table scroll events for patch (#8376)" DNM chore: Revert "chore: revert focus loading indicators and table scroll events for patch (#8376)" Jun 16, 2025
@LFDanLu LFDanLu dismissed stale reviews from yihuiliao and snowystinger via 512e6b4 June 16, 2025 22:09
@LFDanLu LFDanLu changed the title DNM chore: Revert "chore: revert focus loading indicators and table scroll events for patch (#8376)" chore: Revert the revert of "feat: Allow scroll events to be added on certain table components" Jun 16, 2025
@rspbot
Copy link

rspbot commented Jun 16, 2025

Build successful! 🎉

@rspbot
Copy link

rspbot commented Jun 16, 2025

## API Changes

react-aria-components

/react-aria-components:TableHeader

-TableHeader <T extends {}> {
+TableHeader <T extends {}> extends React.HTMLAttributes {
   children?: ReactNode | ({}) => ReactElement
   className?: string | ((TableHeaderRenderProps & {
     defaultClassName: string | undefined
   columns?: Iterable<{}>
   dependencies?: ReadonlyArray<any>
   onHoverChange?: (boolean) => void
   onHoverEnd?: (HoverEvent) => void
   onHoverStart?: (HoverEvent) => void
   style?: CSSProperties | ((TableHeaderRenderProps & {
     defaultStyle: CSSProperties
 })) => CSSProperties | undefined
 }

/react-aria-components:TableBody

-TableBody <T extends {}> {
+TableBody <T extends {}> extends React.HTMLAttributes {
   children?: ReactNode | (T) => ReactNode
   className?: string | ((TableBodyRenderProps & {
     defaultClassName: string | undefined
   dependencies?: ReadonlyArray<any>
   items?: Iterable<T>
   renderEmptyState?: (TableBodyRenderProps) => ReactNode
   style?: CSSProperties | ((TableBodyRenderProps & {
     defaultStyle: CSSProperties
 })) => CSSProperties | undefined
 }

@devongovett
Copy link
Member

Closing now that #8327 is merged.

@devongovett devongovett closed this Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants