Changing test trigger to pull_requests only #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LFDanLu
requested review from
dannify,
devongovett and
snowystinger
as code owners
LFDanLu
changed the title
|
Build successful! View the storybook |
|
Build successful! View the storybook |
Member
Author
|
Closing since we don't want this behavior actually. I'll fix the no-pr build check in a separate PR |
devongovett
added a commit
that referenced
this pull request
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of triggering on every push event, we can trigger on pull request + pull request update (new commits to a pull). This should lower the number of builds and number of errors that occur when the test build tries to comment on a non-existent PR.
If we want a storybook for manual testing before a formal release, we can get one from opening a pull from
mastertonext.See https://help.github.com/en/articles/events-that-trigger-workflows#pull-request-event-pull_request