fix: Canceling text selection in Safari broken after usePress refactor #7774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuiliao
approved these changes
Feb 14, 2025
reidbarber
approved these changes
Feb 14, 2025
snowystinger
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a small regression from the
usePressrefactor: text selection was no longer being canceled in Safari on desktop. For example when clicking quickly on an item in a GridList in the docs the text would be selected. This previously worked becausepreventDefaultstops text selection, but after removing that we rely on settinguser-eventon pointer down. This worked in Chrome and Firefox, but Safari still doesn't supportuser-selectand requires a prefixed-webkit-user-selectproperty instead. Updated the code to detect the correct property to use.