Skip to content

Conversation

@TimonVS
Copy link
Contributor

@TimonVS TimonVS commented Jan 21, 2025

Closes #6159

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

  1. Render a Button
  2. Add aria-current prop with a valid value (e.g., "page")
  3. The rendered button element should have the aria-current attribute with the assigned value

🧢 Your Project:

Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this is a good addition.

@snowystinger snowystinger added this pull request to the merge queue Jan 22, 2025
Merged via the queue into adobe:main with commit 7b7b461 Jan 22, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Button component does not pass aria-current attribute to the button element

3 participants