Skip to content

Conversation

@reidbarber
Copy link
Member

Closes #7242

Our tailwind starter 'Menu' component already renders a Popover:

export function Menu<T extends object>(props: MenuProps<T>) {
return (
<Popover placement={props.placement} className="min-w-[150px]">
<AriaMenu {...props} className="p-1 outline outline-0 max-h-[inherit] overflow-auto [clip-path:inset(0_0_0_0_round_.75rem)]" />
</Popover>
);
}

so we don't need to render a RAC popover in the submenu story. This was causing useSafelyMouseToSubmenu to not work properly.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Test moving mouse to submenu in tailwind starter storybook,

🧢 Your Project:

@reidbarber reidbarber changed the title fix tailwind starter submenu story fix: tailwind starter submenu story Oct 24, 2024
@rspbot
Copy link

rspbot commented Oct 24, 2024

@reidbarber reidbarber added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit e24ea2f Oct 28, 2024
30 of 31 checks passed
@reidbarber reidbarber deleted the fix-tailwind-starter-menu branch October 28, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RAC] Introduce a delay for Menu's submenus closing.

5 participants