fix(RAC): Close tooltip when scrolling #7227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ports adobe#6984 to react-aria-components.
acr92
force-pushed
the
rac/tooltip_stuck_on_screen
branch
from
ffc538b to
dc0436b
Compare
snowystinger
approved these changes
Oct 23, 2024
Member
snowystinger
left a comment
snowystinger
left a comment
There was a problem hiding this comment.
Thank you very much! I tested in Chrome and it's working as expected. Thanks for the test as well!
snowystinger
changed the title
yihuiliao
changed the title
yihuiliao
approved these changes
Oct 24, 2024
Member
yihuiliao
left a comment
yihuiliao
left a comment
There was a problem hiding this comment.
lgtm - tested on chrome, firefox, and safari
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ports #6984 to react-aria-components.
Closes #7226
Related to #6546 (@rtwayland commented that the same issue was in RAC and this fixes it).
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: