Display monopackage imports in the docs when building for production #712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowystinger
reviewed
Jul 9, 2020
yarn.lock
Outdated
| slice-ansi "^4.0.0" | ||
| string-width "^4.2.0" | ||
|
|
||
| "@parcel/codeframe@^2.0.0-alpha.3": |
Member
There was a problem hiding this comment.
no updates to package.json's, why is this getting updated?
I'm ok if you refreshed it on purpose
Member
Author
There was a problem hiding this comment.
I guess it updated when I ran yarn. Perhaps the one on master is out of date?
devongovett
force-pushed
the
monopackage-docs
branch
from
544d4b1 to
789951f
Compare
|
Build successful! 🎉 |
dannify
approved these changes
Jul 10, 2020
|
Build successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #706.
This updates the docs when building for production to show imports to the monopackage instead of the individual packages. This is implemented as a simple babel plugin that runs over each example to convert the imports when needed. With a little hacking, I was also able to avoid needing to convert the AST back to code with babel and then reparse it in prettier by making prettier use the babel ast directly.