Skip to content

Conversation

@LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Sep 21, 2019

Notable changes from jenkins:

  • build and deploy is triggered by pushes made to next branch, no more pressing a button with a drop down selection for patch version
    • As a consequence, the Makefile's lerna version step needs to be manually changed to what kind of release we want to do for now. For now I've set it to lerna version 3.0.0for our first upcoming release. If we adopt conventional commits, I can remove this.

Changes in this pull:

  • all available packages that are slated to go out for our first release have their private: true removed and source/main/files fields in their package.json modified. Root level index.ts has been added so typescript module resolution doesn't trip up from the prior mentioned changes
    • something to note is that some of the Milestone 1 components (e.g. datepicker) have dependencies on components that aren't in Milestone 1 (e.g. calendar)
  • spectrum css package has post css run on it before package publish
    • postcss config stuff has been moved around as a consequence.
  • Makefile build/version/publish changes
  • update to plop stuff so new v3 packages have the same main/source etc configured

TODOs not included in this pull (unless we want these in here as well?):

  • conventional commits so we can do lerna versioning automatically
  • creds for npm publishing and the actual npm registry to which we will publish our packages need to be added
  • exhaustive testing of the packages themselves. I did some testing with a react-create-app but it would be good to do some more
  • merge the rest of the v3 components that exist in the old repo and apply the same changes I made in here to those components. This includes removing private: true, main/source changes, and adding a package root level index.ts
  • add website/doc deploy steps once we actually have a place to put them

just for the first publish, then use conventional commits
 - @adobe/react-spectrum@3.0.0
 - @adobe/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-stately/[email protected]
 - @react-stately/[email protected]
 - @react-stately/[email protected]
 - @react-stately/[email protected]
 - @react-stately/[email protected]
 - @react-stately/[email protected]
 - @react-stately/[email protected]
 - @react-stately/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @spectrum-icons/[email protected]
 - @spectrum-icons/[email protected]
 - @spectrum-icons/[email protected]
 - @spectrum-icons/[email protected]
 - @adobe/react-spectrum@3.0.0
 - @adobe/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-stately/[email protected]
 - @react-stately/[email protected]
 - @react-stately/[email protected]
 - @react-stately/[email protected]
 - @react-stately/[email protected]
 - @react-stately/[email protected]
 - @react-stately/[email protected]
 - @react-stately/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @spectrum-icons/[email protected]
 - @spectrum-icons/[email protected]
 - @spectrum-icons/[email protected]
 - @spectrum-icons/[email protected]
 - @adobe/react-spectrum@3.0.0
 - @adobe/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-aria/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-spectrum/[email protected]
 - @react-stately/[email protected]
 - @react-stately/[email protected]
 - @react-stately/[email protected]
 - @react-stately/[email protected]
 - @react-stately/[email protected]
 - @react-stately/[email protected]
 - @react-stately/[email protected]
 - @react-stately/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @react-types/[email protected]
 - @spectrum-icons/[email protected]
 - @spectrum-icons/[email protected]
 - @spectrum-icons/[email protected]
 - @spectrum-icons/[email protected]
first stab and trying to fix imports
@github-actions
Copy link

Build successful! View the storybook

@LFDanLu LFDanLu changed the title (WIP) Publish workflow Publish workflow Sep 24, 2019
@github-actions
Copy link

Build successful! View the storybook

@dannify
Copy link
Member

dannify commented Oct 10, 2019

Replaced by #17

@dannify dannify closed this Oct 10, 2019
@dannify dannify deleted the test_and_publish_workflow branch October 10, 2019 01:31
devongovett pushed a commit that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants