Skip to content

useLandmark docs: Update category and add aria-label to region example #5509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2023
Merged

useLandmark docs: Update category and add aria-label to region example #5509

merged 1 commit into from
Dec 2, 2023

Conversation

@reidbarber
Copy link
Member

@reidbarber reidbarber commented Dec 1, 2023

  • Updated category to be Interactions
  • Adds an aria-label to the Region in the example

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot
Copy link

rspbot commented Dec 1, 2023

Build successful! 🎉

@LFDanLu LFDanLu changed the title useLandmark docs: Update category and add aria-label to region exmaple useLandmark docs: Update category and add aria-label to region example Dec 1, 2023
LFDanLu
LFDanLu approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that the region now properly announces in NVDA

@adobe adobe deleted a comment from rspbot Dec 1, 2023
@reidbarber reidbarber merged commit fc0e6b6 into main Dec 2, 2023
@reidbarber reidbarber deleted the update-uselandmark-docs branch December 2, 2023 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@snowystinger snowystinger snowystinger approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@reidbarber @rspbot @snowystinger @LFDanLu