Skip to content

Conversation

@ryo-manba
Copy link
Contributor

@ryo-manba ryo-manba commented Nov 18, 2023

Closes #5332

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Verified functionality of onBlur, onFocus, and onFocusChange in Storybook.
Added tests to confirm their operation.

🧢 Your Project:

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, couple items of feedback

@ryo-manba ryo-manba changed the title Add onBlur event handling to useRadioGroup hook Support for focus events in useRadioGroup hooks Nov 20, 2023
@snowystinger
Copy link
Member

GET_BUILD

@rspbot
Copy link

rspbot commented Dec 7, 2023

@rspbot
Copy link

rspbot commented Dec 7, 2023

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally in storybook and verified that the docs reflect the new props, thanks for the contribution!

@LFDanLu LFDanLu merged commit bdd37cd into adobe:main Dec 8, 2023
@ryo-manba ryo-manba deleted the feat/radio-group-onblur branch December 9, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RadioGroup onBlur event prop

4 participants