Convert Picker stories to CSF3 #3713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
snowystinger
reviewed
Nov 4, 2022
snowystinger
reviewed
Nov 4, 2022
snowystinger
previously approved these changes
Nov 4, 2022
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
reidbarber
previously approved these changes
Nov 15, 2022
|
Build successful! 🎉 |
LFDanLu
dismissed stale reviews from reidbarber and snowystinger
via
3257247
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
snowystinger
approved these changes
Nov 18, 2022
ktabors
approved these changes
Nov 19, 2022
|
|
||
| export const Loading: PickerStory = { | ||
| args: { | ||
| children: (item: any) => <Item>{item.name}</Item>, |
Member
There was a problem hiding this comment.
Do we need this in there are no items?
| title: 'Picker', | ||
| component: Picker, | ||
| excludeStories: [], | ||
| args: { |
Member
There was a problem hiding this comment.
Do we want to add props we weren't testing before like direction, shouldFlip?
|
Build successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Split off from #3711 since that PR will need a full csf 3 conversion of all of our stories
✅ Pull Request Checklist:
📝 Test Instructions:
Test Picker stories
🧢 Your Project:
RSP