Upgrade React Transition Group #3706
Conversation
| setScrolling(false); | ||
| }, [virtualizer]); | ||
|
|
||
| let state = useMemo(() => ({ |
There was a problem hiding this comment.
memo state so it doesn't cause unnecessary onLoadMore calls, this appeared after blurring the combobox and it beginning to exit in 16 and 17
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
# Conflicts: # packages/@react-spectrum/list/package.json # packages/@react-spectrum/overlays/package.json
|
Build successful! 🎉 |
| // raf | ||
| act(() => {jest.advanceTimersToNextTimer();}); | ||
| // exited | ||
| act(() => {jest.advanceTimersToNextTimer();}); |
There was a problem hiding this comment.
Why are we wanting to timers so specifically? Verse jest.runAllTimers()
There was a problem hiding this comment.
each timer causes a state change, all state changes must happen within an act, once the act is done, the state changes are resolved. in this case, the state changes must be resolved separately because they influence what happens to the next timer.
there are still instances where you'd want to potentially advance multiple timers at once, which is what happens in the majority of our tests
|
Build successful! 🎉 |
Closes
Precursor to supporting ESM. It'll be easier to review this as a separate PR.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: