Skip to content

Limit TSDiffer comments to one per PR #3700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Nov 16, 2022
Merged

Limit TSDiffer comments to one per PR #3700

merged 15 commits into from
Nov 16, 2022

Conversation

@snowystinger
Copy link
Member

@snowystinger snowystinger commented Oct 31, 2022

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@adobe-bot
Copy link

adobe-bot commented Oct 31, 2022

Build successful! 🎉

@adobe-bot
Copy link

adobe-bot commented Oct 31, 2022

Build successful! 🎉

@adobe-bot
Copy link

adobe-bot commented Oct 31, 2022

Build successful! 🎉

@adobe-bot
Copy link

adobe-bot commented Oct 31, 2022

Build successful! 🎉

@adobe-bot
Copy link

adobe-bot commented Oct 31, 2022

Build successful! 🎉

@adobe-bot
Copy link

adobe-bot commented Oct 31, 2022

Build successful! 🎉

@adobe-bot
Copy link

adobe-bot commented Oct 31, 2022

Build successful! 🎉

@adobe-bot
Copy link

adobe-bot commented Oct 31, 2022

Build successful! 🎉

@adobe-bot
Copy link

adobe-bot commented Oct 31, 2022

Build successful! 🎉

@snowystinger snowystinger marked this pull request as ready for review November 1, 2022 18:17
@adobe-bot
Copy link

adobe-bot commented Nov 1, 2022

Build successful! 🎉

@adobe-bot
Copy link

adobe-bot commented Nov 1, 2022

Build successful! 🎉

@adobe-bot
Copy link

adobe-bot commented Nov 1, 2022

Build successful! 🎉

LFDanLu
LFDanLu approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic looks good to me, lets test it. Remind me, what diff does the CI tsdiff produce? Is it a diff of all api changes since last release or between the branch and main?

@snowystinger
Copy link
Member Author

snowystinger commented Nov 4, 2022 •
edited
Loading

logic looks good to me, lets test it. Remind me, what diff does the CI tsdiff produce? Is it a diff of all api changes since last release or between the branch and main?

Diff is currently between branch and main, latest of both. So if you haven't merged main into your branch in a while, this could produce funny diffs for a little bit. But they'd be resolved by merging main in

I have a different task to eventually get to in order to improve this and diff since the last merge from main

@adobe-bot
Copy link

adobe-bot commented Nov 16, 2022

Build successful! 🎉

ktabors
ktabors approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@ktabors ktabors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please

@snowystinger snowystinger merged commit 70e7caf into main Nov 16, 2022
@snowystinger snowystinger deleted the ts-differ-limit-commenting branch November 16, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktabors ktabors ktabors approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@snowystinger @adobe-bot @ktabors @LFDanLu