React 18 support #3108
Merged
React 18 support #3108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trum into react-18 # Conflicts: # package.json # packages/@react-aria/combobox/test/useComboBox.test.js # packages/@react-aria/tag/test/useTag.test.js # packages/@react-aria/utils/test/useObjectRef.test.js # packages/@react-spectrum/menu/test/MenuTrigger.test.js # packages/@react-spectrum/table/test/Table.test.js # yarn.lock
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
1 task
|
Build successful! 🎉 |
|
Build successful! 🎉 |
# Conflicts: # package.json # packages/@react-aria/dnd/src/useDrag.ts # packages/@react-spectrum/dnd/src/useDragHooks.ts # packages/@react-spectrum/list/src/DragPreview.tsx # packages/@react-spectrum/list/src/ListView.tsx # packages/@react-stately/dnd/src/useDraggableCollectionState.ts # packages/@react-types/shared/src/dnd.d.ts # yarn.lock
|
Build successful! 🎉 |
snowystinger
previously approved these changes
May 19, 2022
Member
snowystinger
left a comment
snowystinger
left a comment
There was a problem hiding this comment.
Code looks good, approving
Wait until testing session is done for merging
|
Build successful! 🎉 |
LFDanLu
previously approved these changes
May 20, 2022
Member
LFDanLu
left a comment
LFDanLu
left a comment
There was a problem hiding this comment.
Did a quick sweep of some components/functionality (liveannouncer, drag preview, etc) and things seems to work. Code looks fine to me as well. Looks like there are some conflicts now, but they seem innocuous (ListView one is just the disabledBehavior stuff from the disabled rows PR)
# Conflicts: # package.json # packages/@react-spectrum/list/src/ListView.tsx # yarn.lock
dannify
previously approved these changes
May 20, 2022
dannify
approved these changes
May 20, 2022
LFDanLu
approved these changes
May 20, 2022
Member
LFDanLu
left a comment
LFDanLu
left a comment
There was a problem hiding this comment.
reapproving, looks fine locally
|
Build successful! 🎉 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2526. Fixes #2800.
This adds basic support for React 18. Strict mode support will be done separately.