Add a script to detect circular dependencies #2851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! 🎉 |
| */ | ||
|
|
||
| import React, {ReactNode, useContext, useMemo, useState} from 'react'; | ||
| import {useLayoutEffect} from '@react-aria/utils'; |
Member
There was a problem hiding this comment.
isn't this the really important place for it, the whole reason we have a useLayoutEffect hook in react-aria/utils is to fix problems with it in SSR?
Member
Author
There was a problem hiding this comment.
Did you see the comment below? I think this one is an exception
dannify
approved these changes
Feb 14, 2022
snowystinger
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had one from
@react-aria/ssr->@react-aria/utils->@react-aria/ssr. Fixed it and added a lint script to check this so it doesn't happen again.