Skip to content

export AsyncListOptions interface #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LFDanLu merged 3 commits into from
Oct 13, 2021
Merged

export AsyncListOptions interface #2417

LFDanLu merged 3 commits into from
Oct 13, 2021

Conversation

@mattywong
Copy link
Contributor

@mattywong mattywong commented Oct 4, 2021

closes #2373

Closes

✅ Pull Request Checklist:

  • [✅ ] Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@LFDanLu
Copy link
Member

LFDanLu commented Oct 12, 2021

@mattywong Apologies for the late update, the change looks fine to me. Mind signing the Adobe CLA so we can get this merged?

@mattywong mattywong closed this Oct 13, 2021
@mattywong mattywong reopened this Oct 13, 2021
LFDanLu
LFDanLu approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LFDanLu LFDanLu merged commit faeb53e into adobe:main Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbarber reidbarber reidbarber approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

@dannify dannify Awaiting requested review from dannify

@devongovett devongovett Awaiting requested review from devongovett

@snowystinger snowystinger Awaiting requested review from snowystinger

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Export out AsyncListOptions in react-stately to allow custom hook implementations to altar useAsyncList options via the parent

3 participants

@mattywong @LFDanLu @reidbarber