Fix eslint errors. #2342
Merged
Fix eslint errors. #2342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dompuiu
requested review from
dannify,
devongovett and
snowystinger
as code owners
dompuiu
commented
Sep 16, 2021
| require.resolve('@react/react-spectrum/Button'); | ||
| } catch (err) { | ||
| mocks['^@react\/.*'] = 'identity-obj-proxy'; | ||
| mocks['^@react/.*'] = 'identity-obj-proxy'; |
Member
Author
There was a problem hiding this comment.
/ does not need to be escaped. \/ is basically /.
dompuiu
commented
Sep 16, 2021
jest.config.js
Outdated
| '\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$': '<rootDir>/__mocks__/fileMock.js', | ||
| '\\.(css|styl)$': 'identity-obj-proxy', | ||
| '\\.\./Icon/.*$': '<rootDir>/__mocks__/iconMock.js', | ||
| '\\.\\./Icon/.*$': '<rootDir>/__mocks__/iconMock.js', |
Member
Author
There was a problem hiding this comment.
\\.\./Icon/.*$ was matching also .a/Icons/something.
dompuiu
commented
Sep 16, 2021
Member
snowystinger
left a comment
snowystinger
left a comment
There was a problem hiding this comment.
Looks good, though I'm not sure what you were running that you saw these as errors? From what I can tell we don't run lint against these files, though we probably should.
Member
Author
|
@snowystinger VSCode automatically runs |
snowystinger
approved these changes
Oct 8, 2021
Member
snowystinger
left a comment
snowystinger
left a comment
There was a problem hiding this comment.
i removed some dead code that used to help us test parity with an earlier version of our library, we don't do that anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was opening the jest config files in VSCode, eslint was complaining about a few errors. This PR tries to fix these errors.
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: