Tooltip design fixes #1515
Tooltip design fixes #1515
Conversation
LFDanLu
requested review from
dannify,
devongovett and
snowystinger
as code owners
|
Build successful! 🎉 |
| import {useTooltipTriggerState} from '@react-stately/tooltip'; | ||
|
|
||
| const DEFAULT_OFFSET = 7; // Closest visual match to Spectrum's mocks | ||
| const DEFAULT_OFFSET = -1; // Closest visual match to Spectrum's mocks |
There was a problem hiding this comment.
the design feedback wanted a distance of 4px between the button and the tooltip while we had a distance of 12px, hence the 7 - 8 = -1 for the default offset here. Didn't want to modify useOverlayPosition's math since that would affect other overlays so went for this default offset modification since we already had it defined
| margin-left: var(--spectrum-tooltip-target-offset); | ||
| &.is-open { | ||
| @inherit: %spectrum-overlay--right--open; | ||
| /* @inherit: %spectrum-overlay--right--open; */ |
There was a problem hiding this comment.
interesting, what was this? and why only comment it out?
There was a problem hiding this comment.
ah whoops, missed that, will fix
| import {useTooltipTriggerState} from '@react-stately/tooltip'; | ||
|
|
||
| const DEFAULT_OFFSET = 7; // Closest visual match to Spectrum's mocks | ||
| const DEFAULT_OFFSET = -1; // Closest visual match to Spectrum's mocks |
There was a problem hiding this comment.
should we change the comment now? I'm assuming this is being added to something
There was a problem hiding this comment.
i forgot to submit my review, you answered the question for @dannify but could you make it a comment?
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Build successful! 🎉 |
Closes #1445
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: