Upgrade ESLint from v4 to v5 #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Upgraded to Note that ESLint now removed support for Node 4 and 5, which is why the Travis build is failing. I.e. this plugin will have to raise support from Node 4 to Node 6 in order to support latest version of ESLint. |
Contributor
Author
|
Upgraded to |
Contributor
Author
|
Upgraded to |
Contributor
Author
|
Upgraded to |
Contributor
Author
|
Upgraded to |
gucong3000
suggested changes
Jun 26, 2018
package.json
Outdated
| "license": "MIT", | ||
| "dependencies": { | ||
| "eslint": "^4.0.0", | ||
| "eslint": "^5.0.0-rc.0", |
There was a problem hiding this comment.
[email protected] has been released
Collaborator
|
@ehmicky Can you finish this up? |
Highlights: * update ESLint form v4 to v5 https://eslint.org/docs/user-guide/migrating-to-5.0.0 * update gulp form v3 to v4 fix #228 close #229 close #230 close #231
shinnn
approved these changes
Jul 5, 2018
Collaborator
shinnn
left a comment
shinnn
left a comment
There was a problem hiding this comment.
I rewrote everything by myself.
Contributor
Author
|
I was in summer vacation. Great this got merged! |
Repository owner
locked as resolved and limited conversation to collaborators
Jul 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades ESLint to the next version.
At the moment, only 5.0.0-alpha.0 is released, so I will update this pull request with newer versions until a stable version is released.