Skip to content

Conversation

@jepler
Copy link

@jepler jepler commented Mar 28, 2018

This appears to have a relatively small impact on flash usage but
fixes some pathological slow behavior putting floats in dicts or sets.

Closes: #704

This appears to have a relatively small impact on flash usage but
fixes some pathological slow behavior putting floats in dicts or sets.

Closes: adafruit#704
@tannewt tannewt self-requested a review March 28, 2018 21:16
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 7b2215a into adafruit:master Mar 28, 2018
@jepler jepler deleted the high-quality-float-hash branch November 3, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hash(float) is not a very good hash function, causes specific performance problem

2 participants