Change I2C terminology from "peripheral" to "target" #6721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Smoke tested on Metro M4 and Feather ESP32 S2 TFT: I created instances of both the old and new names of |
tannewt
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6087.
i2cperipheralmodule toi2ctarget. Keepi2cperipheralas an alias until 9.0.0.I2CPeripheralmodule toI2CTarget. KeepI2CPeripheralas an alias until 9.0.0.The only name I cannot alias is
I2CTargetRequest, which cannot be instantiated directly anyway. So if someone is referencingI2CPeripheralRequest, in say,isinstance(), they will have to change the code. This doesn't seem too likely.