nrf: remove critical section around sd_app_evt_wait() #5202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5182 added a critical section around
sd_app_evt_wait()
, which prevents USB from coming up (and perhaps other things).circuitpython/ports/nrf/supervisor/port.c
Lines 367 to 372 in fdfcaf0
This removes that critical section, which was not present before.
Other uses I see of
sd_app_evt_wait()
don't do anything special (no critical sections, etc.)@tannewt I'm not sure if this the most correct fix, based on what your intention was, which was to shut off as many interrupts as possible and do the equivalent of a WFI. The documentation says the following.