Skip to content

Enable the PWM status LED on Pimoroni Tiny 2040 and PicoSystem #4796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2021

Conversation

Neradoc
Copy link

@Neradoc Neradoc commented May 21, 2021

Found no info on the PicoSystem pwm LED, let's assume it's inverted too until further notice.

@dhalbert
Copy link
Collaborator

@ZodiusInfuser Do you have details on the RGB LEDs on these boards?

@ZodiusInfuser
Copy link

@dhalbert Yes, both boards have a common anode RGB LED, so pins need to be active low.

Do the config changes proposed here allow for that? I am unclear why the pin defines were changed from #define MICROPY_HW_LED_G (&pin_GPIO13) to #define CIRCUITPY_RGB_STATUS_G (&pin_GPIO13)

@Neradoc
Copy link
Author

Neradoc commented May 23, 2021

Yeah the code was tested on the Tiny2040, it blinks as expected from #4743
The defines were changed from CP_RGB_STATUS_G to CIRCUITPY_RGB_STATUS_G in it. I can't find any reference to MICROPY_HW_LED_G in Circuitpython (which explains why it wasn't updated with the others).

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@tannewt
Copy link
Member

tannewt commented May 24, 2021

@ZodiusInfuser I'm not sure they worked as-is. I think this will make it work.

@tannewt tannewt merged commit 038c9d6 into adafruit:main May 24, 2021
@Neradoc Neradoc deleted the nera-pwmrgb-status-pimoroni branch May 28, 2021 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants