raspberrypi: RTC: Ensure a time is set #4379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
previously approved these changes
Mar 11, 2021
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Thanks! Just needs make translate
Until a time is set, the RTC is not running, and rtc_get_datetime() returns false without assigning to the out-parameter. In CircuitPython, this would manifest as arbitrary values being returned, since uninitialized storage on the stack was being converted into a timestamp.
Author
|
@tannewt I had to update the branch so I'll need a re-review. thank you! |
Author
|
@microdev1 I don't know, I would think that after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until a time is set, the RTC is not running, and rtc_get_datetime() returns false without assigning to the out-parameter.
In CircuitPython, this would manifest as arbitrary values being returned by
rtc.RTC().datetime, since uninitialized storage on the stack was being converted into a timestamp.After this change, the RTC starts on January 1, 2020. I think this is the same epoch as the other ports.