Add caveat for usb_cdc.Serial.connected; fix another doc bug #4359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
force-pushed
the
usb_cdc-connect-doc-note
branch
from
adf9233 to
8594396
Compare
dhalbert
changed the title
|
Loosely related to issue #4345: The usb_cdc documentation (https://circuitpython.readthedocs.io/en/latest/shared-bindings/usb_cdc/index.html) is missing the following methods :
Aditionally, it is missing any information about how to change the newline character, if possible at all. |
jepler
previously approved these changes
Mar 7, 2021
|
@dhalbert I think this is good to go but I'm leaving un-merged in case you want to make any change related to @ismael-miguel's review comment (and the build's not finished anyway) |
dhalbert
force-pushed
the
usb_cdc-connect-doc-note
branch
from
1c3a274 to
a147e74
Compare
dhalbert
force-pushed
the
usb_cdc-connect-doc-note
branch
from
a147e74 to
24ac815
Compare
|
Anybody can review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4345.
Fixes #4352.
These are documentation changes only.