Skip to content

Bump circuitpython-stage to 1.1.1 #3503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2020
Merged

Bump circuitpython-stage to 1.1.1 #3503

merged 2 commits into from
Oct 2, 2020

Conversation

deshipu
Copy link

@deshipu deshipu commented Oct 2, 2020

This adds handling of GameOver exception as SystemExit in anticipation
of the new way of starting games from the menu.

This adds handling of GameOver exception as SystemExit in anticipation
of the new way of starting games from the menu.
cwalther
cwalther previously approved these changes Oct 2, 2020
Copy link

@cwalther cwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke-tested on PewPew Standalone 10.2, GameOver in Othello working fine. (Although the display is very flickery and it runs more slowly than with CP 4.1.0, but that is obviously unrelated.)

@deshipu
Copy link
Author

deshipu commented Oct 2, 2020

Ugh, I think the changes around system tick and sleep modes have broken it. I didn't have time to test it, but I've heard reports that gamepad, which also relies on system tick, is unreliable on SAMD21.

@deshipu
Copy link
Author

deshipu commented Oct 2, 2020

@cwalther I reported #3504, hopefully I will be able to look into it this weekend.

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I made the issue blocking the next stable release.

@tannewt tannewt merged commit 62a7ece into adafruit:main Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants