Add bytearray.decode() for CPython compatibility

[theacodes]

CPython has a decode() method on bytearray. This adds that method using the code from bytes.decode.

Test program:

byte_boi = bytes([0x6D, 0x65, 0x65, 0x70])
print(byte_boi)  # b'meep'
byte_boi_str = byte_boi.decode("utf-8")
print(byte_boi_str)  # meep

byte_array_boi = bytearray(byte_boi)
print(byte_array_boi)  # bytearray(b'meep')
byte_array_boi_str = byte_array_boi.decode("utf-8")
print(byte_array_boi_str)  # meep

print(byte_array_boi_str == byte_boi_str)  # True

[tannewt]

Does this unintentionally add it to array objects as well? It shouldn't.

For CPython:

>>> import array
>>> byte_boi = bytes([0x6D, 0x65, 0x65, 0x70])
>>> a = array.array("B", byte_boi)
>>> a.decode("utf-8")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AttributeError: 'array.array' object has no attribute 'decode'

[dhalbert]

Also note this, though I'm not sure whether it's relevant: #384

[theacodes]

Ah it seems like it does add it to array, too. I can fix that if you want.

…

On Fri, May 15, 2020, 12:00 PM Dan Halbert ***@***.***> wrote: Also note this, though I'm not sure whether it's relevant: #384 <#384> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2896 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB5I444WAHHP6QYRT4XRDTRRWGNJANCNFSM4NBHYU4Q> .

[theacodes]

@tannewt made it where decode only applies to bytearray.

print(dir(array.array))
# ['__class__', '__name__', 'append', 'extend']
print(dir(bytearray))
# ['__class__', '__name__', 'append', 'decode', 'extend']

[theacodes]

As I feared, giving bytearray a separate locals table pushed some of the smaller boards over capacity. :(

[dhalbert]

I shrank the crickit build. Let's see if it works.

[theacodes]

Thanks, @dhalbert

[dhalbert]

I'm pretty puzzled by this. I checked out the exact same commit locally (a3ca940), and my builds are about 500 bytes smaller, and they fit. I'm using the same arm-none-eabi-gcc. My regular gcc is newer, but that's just for mpy-cross and shouldn't matter.

EDIT: It was the original commit, not the merge commit.

[dhalbert]

@tannewt it builds now; I think you already took a look so if it's easy for you to finish the review go ahead

[tannewt]

Looks great! Thanks for doing this!