Skip to content

Re-add pairing support #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 22, 2019
Merged

Re-add pairing support #2313

merged 4 commits into from
Nov 22, 2019

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Nov 22, 2019

This adds a pair method to a connection to initiate pairing and a paired attribute to fetch current paired state.

This has only been tested on remotely initiated connections (aka as a peripheral.)

@tannewt tannewt added this to the 5.0.0 milestone Nov 22, 2019
@tannewt tannewt requested a review from dhalbert November 22, 2019 00:42
dhalbert
dhalbert approved these changes Nov 22, 2019
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, pretty much same as before. Hopefully the other-side pairing will just work as well.

@dhalbert dhalbert merged commit c000567 into adafruit:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
circuitpython api enhancement nordic
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tannewt @dhalbert