Add TouchIn "pull_dir" option, touchio works for RP2350 #10223
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #9541, I decided to look into getting
touchioworking for RP2350 without causing too much API change.Here's a first attempt. It adds a new boolean
pull_dirparameter totouchio.TouchIn. Defaulting topull_dir=False,TouchInacts as before. Ifpull_dir=Trueand an external 1M pull-up is wired,TouchInwill now also work on RP2350.I believe this is similar to what DanH was imagining, but much simpler. (It felt odd to me to reuse
digitalio.DigitalInOut.Pullthat has a strong association with built-in pull resistors)Tested on RP2350 and RP2040.