Skip to content

ci_set_matrix: the boards set needs to be a copy #10041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tools/ci_set_matrix.py
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,10 @@ def get_settings(board):
# As a (nearly) last resort, for some certain files, we compute the settings from the
# makefile for each board and determine whether to build them that way
if file.startswith("frozen") or file.startswith("supervisor") or module_matches:
boards = port_to_board[port] if port else all_board_ids
# Take a copy, because we remove items from it below. For
# instance, if we remove items from, say, all_board_ids, then
# the logic to build all boards breaks.
boards = set(port_to_board[port] if port else all_board_ids)

# Zephyr boards don't use make, so build them and don't compute their settings.
for board in port_to_board["zephyr-cp"]:
Expand Down