nRF Port: Get Remaining Shared Modules Working

[sommersoft]

The shared modules below are not currently included in the nRF port build (taken from Makefile). Obviously, some will be easier than others so I put them in as a task list.

• • audiobusio/PDMIn.c now listed in nrf: implement audiobusio.PDMIn #1037
• bitbangio/__init__.c
• bitbangio/I2C.c
• bitbangio/OneWire.c
• bitbangio/SPI.c
• busio/OneWire.c
• gamepad/__init__.c
• gamepad/GamePad.c
• struct/__init__.c
• • uheap/__init__.c now in nrf: implement uheap and ustack #1194
• • ustack/__init__.c now in nrf: implement uheap and ustack #1194

[microbuilder]

Thanks for putting a list together!

[arturo182]

I added gamepad with a example in arturo182@823940e but it is on top of my pca10056 changes and seems github doesn't allow me to push it into a new PR that depends on #573 and I don't want to mix those. So I can wait for this one to be merged before pushing a new PR unless there is some way to do it in a clean way in Github (sorry I come from Gerrit world).

[arturo182]

Added struct in arturo182@71227c5, same story as above :)

[tannewt]

@arturo182 you can do separate PRs if you start new branches locally. Start them based on adafruit's master and they can be reviewed in parallel.

[arturo182]

Yes I am aware of that but it seems Github doesn't support PRs that are on top of other PRs, so I could commit a series of commits and put them into separate commits because the PR will always include all commits not in the main branch. For example the LED fix depends on the nRF52840 PR so I wish i could make a LED PR which is marked to depend on the nRF one and can't be merged until that one is. But I can see how that could get complicated and confusing fast ;)

[tannewt]

Are the shared commits required for your dev setup? You could use rebase to remove the shared commits if not. Waiting is ok too. I'll do the review Tuesday when I have time if @microbuilder doesn't get to it.

[arturo182]

I do some changes in these commits to the pca10056 files that i added in the other PR so I think I'll wait, no hurry TBH ;)

[arturo182]

If I understand correctly the audiobusio module offers a interface for I2S which the nRF52 family has so that module could also be implemented in the nRF port! :)