Skip to content

generate_download_info(): teach it about the language allow list #4470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jepler opened this issue Mar 18, 2021 · 0 comments
Closed

generate_download_info(): teach it about the language allow list #4470

jepler opened this issue Mar 18, 2021 · 0 comments
Labels
bug tooling

Comments

@jepler
Copy link

jepler commented Mar 18, 2021 •
edited
Loading

In #4298 we added an allow list of languages to be built in the github CI. However, this allow list was not taken into account in generate_download_info (inside tools/build_board_info.py).

Move the allow list from tools/build_release_files.py to build_board_info.py, and use it from both places.

While you're in there check if you can use json.write / json.dumps with sort_keys=True
@jepler jepler transferred this issue from adafruit/circuitpython-org Mar 24, 2021
@dhalbert dhalbert mentioned this issue Mar 24, 2021
Merged
Neradoc added a commit to Neradoc/circuitpython that referenced this issue Mar 24, 2021
@Neradoc
implement issue adafruit#4470
36f91fe 
move the language allow list to generate_download_info() and use it there too
jepler added a commit that referenced this issue Mar 25, 2021
@jepler
Merge pull request #4483 from Neradoc/implement-issue-4470
47801bb 
Implement issue #4470
@jepler jepler closed this as completed Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug tooling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jepler